Skip to content

Fixed LGTM and typehint #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 28, 2020
Merged

Fixed LGTM and typehint #3970

merged 4 commits into from
Nov 28, 2020

Conversation

realDuYuanChao
Copy link
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed require descriptive names This PR needs descriptive function and/or variable names labels Nov 27, 2020
@ghost
Copy link

ghost commented Nov 27, 2020 •
edited by poyea
Loading

Pull Request Report

@shellhub Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. There seems to be missing requirements in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths? 🔽

The report contains headings and a checklist where the items are paths to the class/function/parameter where the requirement is missing. Node paths are double colon :: separated names and can be in any of the following format:

  • Class path: [file_name]::[class_name]
  • Function path: [file_name]::[function_name]
  • Function parameter path: [file_name]::[function_name]::[parameter_name]
  • Method path: [file_name]::[class_name]::[function_name]
  • Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following class/functions/parameters require descriptive names:

  • maths/lucas_series.py::recursive_lucas_number::n
  • maths/lucas_series.py::dynamic_lucas_number::n
Relevant links 🔽

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 27, 2020
@dhruvmanila
Copy link
Member

The bot is requesting something :)

poyea
poyea approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed require descriptive names This PR needs descriptive function and/or variable names labels Nov 28, 2020
@ghost ghost added tests are failing Do not merge until tests pass awaiting reviews This PR is ready to be reviewed and removed awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Nov 28, 2020
@poyea poyea merged commit bfb0c35 into TheAlgorithms:master Nov 28, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@realDuYuanChao @poyea @stokhos
Fixed LGTM and typehint (TheAlgorithms#3970)
737e6f7 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@realDuYuanChao @poyea @peRFectBeliever
Fixed LGTM and typehint (TheAlgorithms#3970)
c14d5e3 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@realDuYuanChao @poyea
Fixed LGTM and typehint (TheAlgorithms#3970)
f1023ca 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@realDuYuanChao @poyea @shermanhui
Fixed LGTM and typehint (TheAlgorithms#3970)
b429937 
* fixed LGTM
fixed typehint

* updating DIRECTORY.md

* Update lucas_series.py

* Update lucas_series.py

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

@cclauss cclauss Awaiting requested review from cclauss

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realDuYuanChao @dhruvmanila @poyea